disttask: replace spool with waitgroup

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

• we already handle how many schedulers we can start, we don't need spool which introduces meaningless error handling

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50664 (e7228e4) into master (9f5d216) will decrease coverage by 14.6227%.
Report is 6 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50664         +/-   ##
=================================================
- Coverage   70.3465%   55.7238%   -14.6227%     
=================================================
  Files          1456       1567        +111     
  Lines        420693     588857     +168164     
=================================================
+ Hits         295943     328134      +32191     
- Misses       104421     237919     +133498     
- Partials      20329      22804       +2475     

Flag	Coverage Δ
integration	36.8775% <100.0000%> (?)
unit	70.2588% <100.0000%> (-0.0794%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0269% <ø> (ø)
parser	∅ <ø> (∅)
br	56.7949% <ø> (+6.2378%)	⬆️

[zimulala]

Could we rename Go to RunWithLog or other names which is unify WaitGroupWrapper's functions?

I don't think this function is used anywhere else, so I just mentioned it in this PR.

[D3Hunter]

e7228e4

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ywqzzy, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ywqzzy,zimulala]
• pkg/ddl/OWNERS [ywqzzy,zimulala]
• pkg/disttask/OWNERS [ywqzzy]
• pkg/domain/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-24 02:35:50.571822217 +0000 UTC m=+928192.136119918: ☑️ agreed by zimulala.
• 2024-01-24 02:38:11.956682498 +0000 UTC m=+928333.520980203: ☑️ agreed by ywqzzy.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.