statistics: make the analysis job executable #50499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <[email protected]>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: hi-rustin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50499 +/- ##
=================================================
- Coverage 71.9131% 55.5983% -16.3148%
=================================================
Files 1449 1564 +115
Lines 347105 587956 +240851
=================================================
+ Hits 249614 326894 +77280
- Misses 77205 238242 +161037
- Partials 20286 22820 +2534
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/XL
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-job-execute
branch
from
17a3771 to
4d628f9
Compare
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
qw4990
reviewed
Jan 19, 2024
Comment on lines
47
to
51
| se, err := statsHandle.SPool().Get() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer statsHandle.SPool().Put(se) |
There was a problem hiding this comment.
Should we use CallWithSCtx here?
qw4990
approved these changes
Jan 19, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Signed-off-by: hi-rustin <[email protected]>
hawkingrei
approved these changes
Jan 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #50132
Problem Summary:
What changed and how does it work?
Split from #49418
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.