Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix missing nil check for mv index (#50313) #50342

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50313

What problem does this PR solve?

Issue Number: close #50298

Problem Summary:

Estimation logic for mv index access path will meet panic if it's a new index without stats.

What changed and how does it work?

Add a nil check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.6@a0ce8e0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.6     #50342   +/-   ##
================================================
  Coverage               ?   70.0117%           
================================================
  Files                  ?       1436           
  Lines                  ?     419107           
  Branches               ?          0           
================================================
  Hits                   ?     293424           
  Misses                 ?     105383           
  Partials               ?      20300           
Flag Coverage Δ
unit 70.0117% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 49.6569% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 11:58:25.563340484 +0000 UTC m=+530895.147594175: ☑️ agreed by AilinKid.
  • 2024-01-11 12:59:09.57324993 +0000 UTC m=+534539.157503617: ☑️ agreed by time-and-fate.

@time-and-fate
Copy link
Member

/test mysql-test

Copy link

tiprow bot commented Jan 11, 2024

@time-and-fate: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit a0a9c5e into pingcap:release-7.6 Jan 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants