Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: change extra running subtasks to pending #50266

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

  • change extra running subtasks to pending, so they could be balanced to other node
  • fix bug that startCancelCheck queries all subtasks, but we only schedule subtasks of current step during balance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 10, 2024
@D3Hunter D3Hunter requested a review from ywqzzy January 10, 2024 08:11
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2024
Copy link

tiprow bot commented Jan 10, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #50266 (4aaf243) into master (1c4b27c) will decrease coverage by 14.3165%.
The diff coverage is 91.9191%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50266         +/-   ##
=================================================
- Coverage   70.0102%   55.6937%   -14.3165%     
=================================================
  Files          1444       1550        +106     
  Lines        419954     582591     +162637     
=================================================
+ Hits         294011     324467      +30456     
- Misses       105629     235407     +129778     
- Partials      20314      22717       +2403     
Flag Coverage Δ
integration 36.4092% <49.4382%> (?)
unit 69.9895% <92.7835%> (-0.0208%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.2282% <ø> (+5.5515%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2024
Copy link

ti-chi-bot bot commented Jan 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 03:41:14.969982587 +0000 UTC m=+501064.554236493: ☑️ agreed by okJiang.
  • 2024-01-12 02:53:03.925285661 +0000 UTC m=+584573.509539356: ☑️ agreed by ywqzzy.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 12, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 17d65b9 into pingcap:master Jan 12, 2024
21 checks passed
@D3Hunter D3Hunter deleted the running-2-pending branch January 12, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants