Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: merge handle task loop #50224

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jan 9, 2024

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

  • merge fetchAndHandleRunnableTasksLoop and fetchAndFastCancelTasksLoop into handleTasksLoop
  • remove useless taskExecutor.Pause

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2024
Copy link

tiprow bot commented Jan 9, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

for {
select {
case <-m.ctx.Done():
m.cancelAllRunningTasks()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove duplicate cancel

Comment on lines -447 to -449
case proto.TaskStatePausing:
// use m.ctx since this process should not be canceled.
err = executor.Pause(m.ctx, task)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreachable, prev state check will return directly

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #50224 (cd3cd6d) into master (56c619f) will decrease coverage by 14.7369%.
Report is 3 commits behind head on master.
The diff coverage is 97.8723%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50224         +/-   ##
=================================================
- Coverage   70.1081%   55.3713%   -14.7369%     
=================================================
  Files          1442       1553        +111     
  Lines        419730     586594     +166864     
=================================================
+ Hits         294265     324805      +30540     
- Misses       105216     239122     +133906     
- Partials      20249      22667       +2418     
Flag Coverage Δ
integration 36.5485% <80.8510%> (?)
unit 70.0210% <97.8723%> (-0.0872%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 55.5063% <ø> (+5.7746%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2024
@D3Hunter D3Hunter requested a review from okJiang January 9, 2024 05:56
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 9, 2024

/retest

Copy link

tiprow bot commented Jan 9, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 05:50:42.887423284 +0000 UTC m=+336032.471676969: ☑️ agreed by ywqzzy.
  • 2024-01-10 02:07:45.852251109 +0000 UTC m=+409055.436504793: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 91661e1 into pingcap:master Jan 10, 2024
22 checks passed
@D3Hunter D3Hunter deleted the merge-loop branch January 10, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants