Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ignore paths in .codecov.yml #50175

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 8, 2024

What problem does this PR solve?

Issue Number: close #50174

Problem Summary:

What changed and how does it work?

Fix ignore paths in .codecov.yaml
Ref: https://docs.codecov.com/docs/ignoring-paths

# sample regex patterns
ignore:
  - "path/to/folder"  # ignore folders and all its contents
  - "test_*.rb"       # wildcards accepted
  - "**/*.py"         # glob accepted

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Ref: https://docs.codecov.com/docs/ignoring-paths

```yaml
# sample regex patterns
ignore:
  - "path/to/folder"  # ignore folders and all its contents
  - "test_*.rb"       # wildcards accepted
  - "**/*.py"         # glob accepted
```
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 8, 2024
Copy link

tiprow bot commented Jan 8, 2024

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.codecov.yml Outdated Show resolved Hide resolved
@JasonWu0506
Copy link

/LGTM

Copy link

ti-chi-bot bot commented Jan 8, 2024

@JasonWu0506: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@wuhuizuo wuhuizuo changed the title chore: fix ignore paths .codecov.yml chore: fix ignore paths in .codecov.yml Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Merging #50175 (b4ff89a) into master (5fe0847) will decrease coverage by 23.7759%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50175         +/-   ##
=================================================
- Coverage   79.2973%   55.5214%   -23.7759%     
=================================================
  Files          2447       1545        -902     
  Lines        673721     584363      -89358     
=================================================
- Hits         534243     324447     -209796     
- Misses       118076     237202     +119126     
- Partials      21402      22714       +1312     
Flag Coverage Δ
integration 36.8555% <ø> (?)
unit 70.0815% <ø> (-9.2159%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-19.5862%) ⬇️
parser ∅ <ø> (∅)
br 55.6748% <ø> (-12.8159%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2024
Copy link

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, JasonWu0506, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2024
Copy link

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 06:30:52.776308682 +0000 UTC m=+252042.360562371: ☑️ agreed by hawkingrei.
  • 2024-01-08 06:33:19.290629272 +0000 UTC m=+252188.874882958: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member

/retest

Copy link

tiprow bot commented Jan 8, 2024

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test b4ff89a link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1952a70 into master Jan 8, 2024
19 of 20 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/codecov-ignore-paths branch January 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb repo codecov: no need to upload *_test.go coverage
4 participants