Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: avoid allocating the memory when to auto analyze with pseudo table #50099

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 4, 2024

What problem does this PR solve?

Issue Number: close #50100

Problem Summary:

What changed and how does it work?

7lrCfcUNzi

when we meet the many pseudo tables to check whether to do auto-analyze. we will create many pseudo statistics. it will lead to frequent gc.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 4, 2024
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. do-not-merge/needs-tests-checked labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #50099 (2268010) into master (617eb0a) will increase coverage by 2.9334%.
Report is 12 commits behind head on master.
The diff coverage is 86.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50099        +/-   ##
================================================
+ Coverage   79.3332%   82.2667%   +2.9334%     
================================================
  Files          2442       2447         +5     
  Lines        673096     678938      +5842     
================================================
+ Hits         533989     558540     +24551     
+ Misses       117778      99806     -17972     
+ Partials      21329      20592       -737     
Flag Coverage Δ
integration 49.5885% <60.0000%> (?)
unit 79.6668% <86.6666%> (+0.3335%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (ø)
parser ∅ <ø> (∅)
br 71.8660% <ø> (+3.3444%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 5, 2024
@hawkingrei hawkingrei requested review from Rustin170506, time-and-fate and qw4990 and removed request for Rustin170506, time-and-fate and qw4990 January 5, 2024 01:01
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2024
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2024
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
@hawkingrei
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2024
Copy link

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 03:47:18.951889973 +0000 UTC m=+2401529.989116900: ☑️ agreed by hi-rustin.
  • 2024-01-05 07:22:57.101613439 +0000 UTC m=+2414468.138840351: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 7e83932 into pingcap:master Jan 5, 2024
20 checks passed
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024
@hawkingrei hawkingrei deleted the avoid_pseudo_create branch February 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid allocating the memory when to auto analyze with pseudo table
3 participants