ddl: fix unstable test TestCreateDropCreateTable

[tangenta]

What problem does this PR solve?

Issue Number: close #50061

Problem Summary:

There is a gap between runningJobs.remove() and next runningJobs.add(). If getJob() is invoked during this gap, DDL worker may execute the second create table job first.

What changed and how does it work?

This PR distinguishes the concept between "processing" jobs and "unfinished" jobs:

• Processing jobs: activatly running by a DDL worker.
• Unfinished jobs: the jobs whose state is NOT synced, done, or rollback done.

For checkRunnable(), we should use "unfinished jobs" to determine the dependency.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50076 (2089e71) into master (c128a2d) will increase coverage by 2.0105%.
Report is 6 commits behind head on master.
The diff coverage is 90.9090%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #50076        +/-   ##
================================================
+ Coverage   70.7820%   72.7926%   +2.0105%     
================================================
  Files          1467       1467                
  Lines        436396     437267       +871     
================================================
+ Hits         308890     318298      +9408     
+ Misses       108168      98944      -9224     
- Partials      19338      20025       +687     

Flag	Coverage Δ
integration	48.9578% <88.6363%> (?)
unit	70.4748% <88.6363%> (-0.1079%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.4462% <ø> (+5.5748%)	⬆️

[tangenta]

/ok-to-test

[tangenta]

/retest

[tangenta]

/retest

[tangenta]

/retest

[tangenta]

@wuhuizuo I need to trigger CI to reproduce the issue.

[tangenta]

/run-unit-test

[bb7133]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-07 15:52:48.484469112 +0000 UTC m=+355195.506715500: ☑️ agreed by wjhuang2016.
• 2024-03-07 19:45:27.964956004 +0000 UTC m=+369154.987202391: ☑️ agreed by bb7133.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #53635.