makefile: simplify code #50054
Merged
makefile: simplify code #50054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
hawkingrei
added
skip-issue-check
ti-chi-bot
bot
added
size/XS
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50054 +/- ##
================================================
+ Coverage 71.9162% 81.9101% +9.9938%
================================================
Files 1439 2442 +1003
Lines 346158 673145 +326987
================================================
+ Hits 248944 551374 +302430
- Misses 76967 101030 +24063
- Partials 20247 20741 +494
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lance6716
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
Defined2014
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
xhebox
approved these changes
Jan 4, 2024
|
/retest |
|
/test all |
ngaut
approved these changes
Jan 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lance6716, ngaut, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
simple_instrumentation_filter
branch
from
70a0ad8 to
0ac9b75
Compare
Signed-off-by: Weizhen Wang <[email protected]>
AilinKid
pushed a commit
to AilinKid/tidb
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.