*: use errctx to handle divide zero error #50042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
lcwangchao
added
the
compatibility-breaker
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50042 +/- ##
=================================================
+ Coverage 71.8820% 81.8990% +10.0169%
=================================================
Files 1439 2442 +1003
Lines 346160 673020 +326860
=================================================
+ Hits 248827 551197 +302370
- Misses 77058 101084 +24026
- Partials 20275 20739 +464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lcwangchao
force-pushed
the
errctx_div_zero
branch
5 times, most recently
from
193ef18 to
01233c9
Compare
lcwangchao
removed
the
compatibility-breaker
lcwangchao
force-pushed
the
errctx_div_zero
branch
6 times, most recently
from
a57f791 to
56ddaee
Compare
|
/hold wait #5007 merged first |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/approve |
lcwangchao
force-pushed
the
errctx_div_zero
branch
from
56ddaee to
b37d083
Compare
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
tangenta
reviewed
Jan 4, 2024
tangenta
reviewed
Jan 4, 2024
lcwangchao
force-pushed
the
errctx_div_zero
branch
from
b37d083 to
2c7472e
Compare
lcwangchao
force-pushed
the
errctx_div_zero
branch
from
2c7472e to
05cff48
Compare
tangenta
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
XuHuaiyu
approved these changes
Jan 5, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #50041
What changed and how does it work?
use errctx to handle divide zero error
StatementContext.DividedByZeroAsWarningand use the error groupErrDivisionByZeroto mark the error handle level.StatementContext.InReorgbecause it is useless now.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.