-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: use EncodeKey to encode groupkey in StreamAggExec (#49974) #50024
executor: use EncodeKey to encode groupkey in StreamAggExec (#49974) #50024
Conversation
e31e15c
to
65cf090
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #50024 +/- ##
================================================
Coverage ? 73.6873%
================================================
Files ? 1090
Lines ? 349930
Branches ? 0
================================================
Hits ? 257854
Misses ? 75521
Partials ? 16555 |
This is an automated cherry-pick of #49974
What problem does this PR solve?
Issue Number: close #49902
Problem Summary:
What changed and how does it work?
Use
EncodeKey
function to encode thegroupkey
withinStreamAggExec
. This approach is necessary as it considers collation when aggregating the result.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.