-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix unexpected mpp grpc EOF error log #50010
Conversation
Signed-off-by: guo-shaoge <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50010 +/- ##
================================================
- Coverage 71.9115% 68.7933% -3.1182%
================================================
Files 1438 1440 +2
Lines 345747 408596 +62849
================================================
+ Hits 248632 281087 +32455
- Misses 76855 108507 +31652
+ Partials 20260 19002 -1258
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #50011
Problem Summary: introduced by https://github.com/pingcap/tidb/pull/49401/files#diff-bb7331df1642b992efeb5699402d591f45fbc8b9baec6c024680156ae3a5656aR522
What changed and how does it work?
EOF
error of grpc streamRecv()
indicates a stream completes successfully, ref: https://github.com/grpc/grpc-go/blob/master/stream.go#L134Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.