Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix unexpected mpp grpc EOF error log #50010

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Jan 3, 2024

What problem does this PR solve?

Issue Number: close #50011

Problem Summary: introduced by https://github.com/pingcap/tidb/pull/49401/files#diff-bb7331df1642b992efeb5699402d591f45fbc8b9baec6c024680156ae3a5656aR522

What changed and how does it work?

EOF error of grpc stream Recv() indicates a stream completes successfully, ref: https://github.com/grpc/grpc-go/blob/master/stream.go#L134

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Merging #50010 (7632681) into master (37c7326) will decrease coverage by 3.1182%.
Report is 8 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50010        +/-   ##
================================================
- Coverage   71.9115%   68.7933%   -3.1182%     
================================================
  Files          1438       1440         +2     
  Lines        345747     408596     +62849     
================================================
+ Hits         248632     281087     +32455     
- Misses        76855     108507     +31652     
+ Partials      20260      19002      -1258     
Flag Coverage Δ
integration 44.1167% <0.0000%> (?)
unit 71.9680% <ø> (+0.0565%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.3129% <ø> (ø)
parser ∅ <ø> (∅)
br 43.9659% <ø> (-7.6422%) ⬇️

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [windtalker,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2024
Copy link

ti-chi-bot bot commented Jan 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-03 06:13:59.651113172 +0000 UTC m=+2237530.688340094: ☑️ agreed by wshwsh12.
  • 2024-01-03 06:27:47.165990739 +0000 UTC m=+2238358.203217667: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit b50b151 into pingcap:master Jan 3, 2024
18 checks passed
@guo-shaoge guo-shaoge deleted the fix_useless_log branch January 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected mpp grpc EOF error log
3 participants