Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: re-enable analyze for mv index and code prepare for estimation | tidb-test=pr/2272 #49937

Merged

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Dec 29, 2023

What problem does this PR solve?

Issue Number: ref #46539

What changed and how does it work?

  • Re-enable analyze for mv index. (pkg/planner/core/planbuilder.go)
  • Change parameters for some functions related to mv index access path. It's a preparation for the following PR that adds support for estimation for mv index access path. (pkg/planner/core/indexmerge_path.go, pkg/planner/core/logical_plans.go)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Merging #49937 (08f7045) into master (d6aeaf0) will decrease coverage by 0.9262%.
Report is 11 commits behind head on master.
The diff coverage is 96.7741%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49937        +/-   ##
================================================
- Coverage   72.0575%   71.1314%   -0.9262%     
================================================
  Files          1437       1433         -4     
  Lines        345628     417620     +71992     
================================================
+ Hits         249051     297059     +48008     
- Misses        76506     101771     +25265     
+ Partials      20071      18790      -1281     
Flag Coverage Δ
integration 44.1308% <96.7741%> (?)
unit 70.9408% <ø> (-1.1168%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (-2.3466%) ⬇️
parser ∅ <ø> (∅)
br 46.8935% <ø> (-4.5056%) ⬇️

@time-and-fate time-and-fate changed the title planner: re-enable analyze for mv index | tidb-test=pr/2272 planner: re-enable analyze for mv index and code prepare for estimation | tidb-test=pr/2272 Jan 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2024
Copy link

ti-chi-bot bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2024
Copy link

ti-chi-bot bot commented Jan 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-02 08:11:39.352759283 +0000 UTC m=+2158190.389986204: ☑️ agreed by qw4990.
  • 2024-01-02 08:17:24.602791953 +0000 UTC m=+2158535.640018880: ☑️ agreed by AilinKid.

@time-and-fate
Copy link
Member Author

/test mysql-test

Copy link

tiprow bot commented Jan 2, 2024

@time-and-fate: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@time-and-fate
Copy link
Member Author

/test check-dev2

Copy link

tiprow bot commented Jan 2, 2024

@time-and-fate: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 2d7d83d into pingcap:master Jan 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants