-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomod: update pd client to fix follower selection #49860
Conversation
Hi @HuSharp. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: husharp <[email protected]>
b35f4dd
to
2ea80b9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49860 +/- ##
================================================
+ Coverage 70.9362% 71.3250% +0.3887%
================================================
Files 1368 1430 +62
Lines 396054 415735 +19681
================================================
+ Hits 280946 296523 +15577
- Misses 95443 100416 +4973
+ Partials 19665 18796 -869
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lance6716 @CabinfeverB PTAL, thx! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CabinfeverB, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #49744
Problem Summary:
What changed and how does it work?
Due to https://github.com/tikv/pd/blob/master/client/http/client.go#L164 check, when leaderIdx is 0, will not enter loop
fixed in PD tikv/pd#7622
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.