Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update pd client to fix follower selection #49860

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 27, 2023

What problem does this PR solve?

Issue Number: close #49744

Problem Summary:

What changed and how does it work?

Due to https://github.com/tikv/pd/blob/master/client/http/client.go#L164 check, when leaderIdx is 0, will not enter loop

fixed in PD tikv/pd#7622

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2023
Copy link

tiprow bot commented Dec 27, 2023

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the fix_pd_client_follower branch from b35f4dd to 2ea80b9 Compare December 27, 2023 13:07
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #49860 (2ea80b9) into master (ed291b8) will increase coverage by 0.3887%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49860        +/-   ##
================================================
+ Coverage   70.9362%   71.3250%   +0.3887%     
================================================
  Files          1368       1430        +62     
  Lines        396054     415735     +19681     
================================================
+ Hits         280946     296523     +15577     
- Misses        95443     100416      +4973     
+ Partials      19665      18796       -869     
Flag Coverage Δ
integration 43.8200% <ø> (?)
unit 70.9362% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.1800% <ø> (-5.6984%) ⬇️

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 28, 2023

@lance6716 @CabinfeverB PTAL, thx!

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 28, 2023
Copy link

ti-chi-bot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
Copy link

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-28 01:52:17.426353767 +0000 UTC m=+1703428.463580691: ☑️ agreed by CabinfeverB.
  • 2023-12-28 02:04:30.192155624 +0000 UTC m=+1704161.229382550: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit fa3c49b into pingcap:master Dec 28, 2023
17 of 18 checks passed
@HuSharp HuSharp deleted the fix_pd_client_follower branch December 28, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lightning failed with '503 Service Unavailable' when inject pd leader network partition
3 participants