Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix between ... and ... get wrong result for partition table #49853

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #49842

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 27, 2023
Copy link

tiprow bot commented Dec 27, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #49853 (5d12e06) into master (75b451c) will increase coverage by 0.2022%.
Report is 33 commits behind head on master.
The diff coverage is 80.4347%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49853        +/-   ##
================================================
+ Coverage   70.9244%   71.1267%   +0.2022%     
================================================
  Files          1368       1430        +62     
  Lines        396261     417566     +21305     
================================================
+ Hits         281046     297001     +15955     
- Misses        95540     101736      +6196     
+ Partials      19675      18829       -846     
Flag Coverage Δ
integration 43.8191% <80.4347%> (?)
unit 70.9235% <ø> (-0.0009%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5955% <ø> (-6.3078%) ⬇️

@Defined2014 Defined2014 changed the title planner: fix between ... and ... stmt for partition table planner: fix between ... and ... get wrong result for partition table Dec 28, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
@Defined2014
Copy link
Contributor Author

/cc @mjonss PTAL

Copy link

ti-chi-bot bot commented Dec 28, 2023

@Defined2014: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mjonss PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tiancaiamao,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2023
Copy link

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-28 06:27:44.686976997 +0000 UTC m=+1719955.724203909: ☑️ agreed by wjhuang2016.
  • 2023-12-29 07:30:46.338142566 +0000 UTC m=+1810137.375369485: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit 3fd9eaa into pingcap:master Dec 29, 2023
17 of 18 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49923.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49924.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #49925.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 29, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #49926.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect tableDual plan caused by corner case values and partition
4 participants