Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update pd-client and client-go #49833

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Dec 27, 2023

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Dec 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2023
Copy link

tiprow bot commented Dec 27, 2023

Hi @glorv. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2023
@glorv
Copy link
Contributor Author

glorv commented Dec 27, 2023

/ok-to-test

@glorv glorv marked this pull request as ready for review December 27, 2023 07:18
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2023
@glorv glorv requested review from nolouch and wjhuang2016 December 27, 2023 07:18
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #49833 (d35f374) into master (1fb5a9a) will increase coverage by 0.2378%.
Report is 10 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49833        +/-   ##
================================================
+ Coverage   70.9219%   71.1597%   +0.2378%     
================================================
  Files          1368       1430        +62     
  Lines        396364     418266     +21902     
================================================
+ Hits         281109     297637     +16528     
- Misses        95564     101784      +6220     
+ Partials      19691      18845       -846     
Flag Coverage Δ
integration 43.9585% <50.0000%> (?)
unit 70.9217% <ø> (-0.0002%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5939% <ø> (-6.3094%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 07:28:59.638550797 +0000 UTC m=+1637230.675777706: ☑️ agreed by nolouch.
  • 2023-12-27 07:33:55.240929548 +0000 UTC m=+1637526.278156475: ☑️ agreed by wjhuang2016.

@glorv
Copy link
Contributor Author

glorv commented Dec 27, 2023

/retest

@glorv
Copy link
Contributor Author

glorv commented Dec 27, 2023

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, nolouch, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit ed291b8 into pingcap:master Dec 27, 2023
18 checks passed
@glorv glorv deleted the update-pd-client branch December 28, 2023 02:21
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 18, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51121.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Apr 18, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52703.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants