-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: cp refactor planner module's warning and note generation logic (get rid of unnecessary stack info) (#49390) #49708
Conversation
…(get rid of unnecessary stack info) (pingcap#49390) close pingcap#49291
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #49708 +/- ##
================================================
Coverage ? 73.4296%
================================================
Files ? 1207
Lines ? 378648
Branches ? 0
================================================
Hits ? 278040
Misses ? 82859
Partials ? 17749 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seiya-annie: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990, seiya-annie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close #49291
What problem does this PR solve?
Issue Number: close #49291
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.