-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: backup/restore statistic data in the partition dimension #49628
br: backup/restore statistic data in the partition dimension #49628
Conversation
Signed-off-by: Leavrth <[email protected]>
br/pkg/metautil/load.go
Outdated
@@ -0,0 +1,75 @@ | |||
// Copyright 2023 PingCAP, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly move code from utils/schema.go
.
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
/test pull-br-integration-test |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49628 +/- ##
=================================================
- Coverage 79.3020% 67.3283% -11.9737%
=================================================
Files 2447 2561 +114
Lines 673965 841957 +167992
=================================================
+ Hits 534468 566876 +32408
- Misses 118116 251297 +133181
- Partials 21381 23784 +2403
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Leavrth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
/retest |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@Leavrth: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
@Leavrth: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #49627
Problem Summary:
oom when backup/restore the statistic if there are many partitions of a table
What changed and how does it work?
backup/restore statistic data in the partition dimension
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.