global sort: fix broken prop with onefile writer #49589
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
|
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-tests-checked
do-not-merge/needs-linked-issue
labels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49589 +/- ##
================================================
+ Coverage 71.0024% 71.6419% +0.6395%
================================================
Files 1368 1423 +55
Lines 399178 418371 +19193
================================================
+ Hits 283426 299729 +16303
- Misses 95967 99912 +3945
+ Partials 19785 18730 -1055
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -148,7 +148,7 @@ func TestGlobalSortLocalWithMerge(t *testing.T) { | |||
| startKey = BytesMin(startKey, s.Min.Clone()) | |||
| endKey = BytesMax(endKey, s.Max.Clone().Next()) | |||
| } | |||
|
|
|||
| mergeMemSize := (rand.Intn(10) + 1) * 100 | |||
There was a problem hiding this comment.
what does this “mergeMemSize := (rand.Intn(10) + 1) * 100” mean, why here use a random func?
There was a problem hiding this comment.
Make the test run more cases to check different memSize/blockSize of writer can be used for writer.
When memSize is small enough, we will reach line 109 in onefile writer, hopefully the bug will reproduce.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
| @@ -761,6 +763,7 @@ var ( | |||
| concurrency = flag.Int("concurrency", 100, "concurrency") | |||
| memoryLimit = flag.Int("memory-limit", 64*units.MiB, "memory limit") | |||
| skipCreate = flag.Bool("skip-create", false, "skip create files") | |||
| fileName = flag.String("file-name", "test", "test") | |||
There was a problem hiding this comment.
oops, I will rename it
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #49590
Problem Summary:
What changed and how does it work?
When exceed writer memlimit, create new prop with kv.offset.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.