Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: only query locks once (#49473) #49554

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49473

What problem does this PR solve?

Issue Number: close #49472

Problem Summary:

What changed and how does it work?

  • Only queried the lock information once.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added component/statistics release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 18, 2023
13 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 25, 2024
Copy link

ti-chi-bot bot commented Jan 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 05:37:44.470981049 +0000 UTC m=+939355.508207961: ☑️ agreed by hawkingrei.
  • 2024-01-25 03:19:07.060807231 +0000 UTC m=+1017188.625104932: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@3ac58a9). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #49554   +/-   ##
================================================
  Coverage               ?   72.0097%           
================================================
  Files                  ?       1400           
  Lines                  ?     406624           
  Branches               ?          0           
================================================
  Hits                   ?     292809           
  Misses                 ?      94139           
  Partials               ?      19676           
Flag Coverage Δ
unit 72.0097% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3124% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit e90e302 into pingcap:release-7.5 Jan 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/statistics lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants