statistics: skip auto-analyze when it is executed outside the available time period #49541

hawkingrei · 2023-12-18T05:04:16Z

What problem does this PR solve?

Issue Number: close #49552

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

codecov · 2023-12-18T05:20:27Z

Codecov Report

Merging #49541 (ebee5cd) into master (8ed0d47) will increase coverage by 0.5172%.
Report is 4 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49541        +/-   ##
================================================
+ Coverage   71.0034%   71.5206%   +0.5172%     
================================================
  Files          1368       1419        +51     
  Lines        399351     415396     +16045     
================================================
+ Hits         283553     297094     +13541     
- Misses        96007      99511      +3504     
+ Partials      19791      18791      -1000

Flag	Coverage Δ
integration	`43.8523% <0.0000%> (?)`
unit	`71.0034% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9663% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`47.7694% <ø> (-5.1237%)`	⬇️

hawkingrei · 2023-12-18T11:47:49Z

/retest

…he available time period Signed-off-by: Weizhen Wang <[email protected]>

Signed-off-by: Weizhen Wang <[email protected]>

pkg/statistics/handle/autoanalyze/autoanalyze.go

Signed-off-by: Weizhen Wang <[email protected]>

Rustin170506

rest LGTM.

Approve in advance. Please fix the nit issues.

pkg/statistics/handle/autoanalyze/autoanalyze.go

Rustin170506 · 2023-12-19T03:16:15Z

pkg/statistics/handle/autoanalyze/autoanalyze.go

@@ -392,6 +395,9 @@ func randomPickOneTableAndTryAutoAnalyze(

 		// We need to check every partition of every table to see if it needs to be analyzed.
 		for _, tbl := range tbls {
+			if !timeutil.WithinDayTimePeriod(start, end, time.Now()) {


Could you please comment on why it is necessary to check it repeatedly?

OK, I added.

Rustin170506 · 2023-12-19T03:18:23Z

pkg/statistics/handle/autoanalyze/autoanalyze_test.go

+	}
+	se, err := dom.SysSessionPool().Get()
+	require.NoError(t, err)
+	require.False(t, autoanalyze.RandomPickOneTableAndTryAutoAnalyze(se.(sessionctx.Context), dom.StatsHandle(), dom.SysProcTracker(), dom.InfoSchema(), 0.6, variable.Dynamic, ttStart, ttEnd))


This line appears to be a bit lengthy. Would it be better if we break it down?

ti-chi-bot · 2023-12-19T03:49:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hi-rustin,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-12-19T03:49:43Z

[LGTM Timeline notifier]

Timeline:

2023-12-19 03:19:39.484284875 +0000 UTC m=+931070.521511803: ☑️ agreed by hi-rustin.
2023-12-19 03:49:42.399910425 +0000 UTC m=+932873.437137354: ☑️ agreed by time-and-fate.

time-and-fate · 2023-12-19T03:49:48Z

/hold

Feel free to /unhold it when you are ready to merge it.

Co-authored-by: Rustin Liu <[email protected]>

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2023-12-19T04:26:30Z

/unhold

hawkingrei · 2023-12-19T05:36:47Z

/cherrypick release-7.5

ti-chi-bot · 2023-12-19T05:37:29Z

@hawkingrei: new pull request created to branch release-7.5: #49577.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-01-31T14:09:33Z

/cherry-pick release-7.5

ti-chi-bot · 2024-01-31T14:10:18Z

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-49541-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-49541-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

ti-chi-bot · 2024-01-31T14:10:57Z

@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-49541-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-49541-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…le time period (#49541) (#49577) close #49552

hawkingrei · 2024-03-26T05:46:14Z

/cherrypick release-7.1
/cherrypick release-6.5

ti-chi-bot · 2024-03-26T05:46:58Z

@hawkingrei: new pull request created to branch release-6.5: #52097.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-03-26T05:47:40Z

@hawkingrei: new pull request created to branch release-7.1: #52098.

In response to this:

/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

…le time period (#49541) (#52097) close #49552

…le time period (#49541) (#52098) close #49552

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2023

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Dec 18, 2023

hawkingrei added 5 commits December 18, 2023 19:48

statistics: skip auto-analyze when auto analyze is executed outside t…

4436761

…he available time period Signed-off-by: Weizhen Wang <[email protected]>

update

a91a940

Signed-off-by: Weizhen Wang <[email protected]>

update

450d6af

Signed-off-by: Weizhen Wang <[email protected]>

update

a962e64

Signed-off-by: Weizhen Wang <[email protected]>

update

a5bf3ae

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei force-pushed the check_time_duration_analyze branch from 7d3553c to a5bf3ae Compare December 18, 2023 11:48

update

681c377

Signed-off-by: Weizhen Wang <[email protected]>

time-and-fate reviewed Dec 18, 2023

View reviewed changes

pkg/statistics/handle/autoanalyze/autoanalyze.go Outdated Show resolved Hide resolved

update

3e35096

Signed-off-by: Weizhen Wang <[email protected]>

Rustin170506 approved these changes Dec 19, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023

time-and-fate approved these changes Dec 19, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023

Update pkg/statistics/handle/autoanalyze/autoanalyze.go

d43837f

Co-authored-by: Rustin Liu <[email protected]>

update

ebee5cd

Signed-off-by: Weizhen Wang <[email protected]>

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023

ti-chi-bot bot merged commit 3a50bf6 into pingcap:master Dec 19, 2023
16 checks passed

hawkingrei deleted the check_time_duration_analyze branch December 19, 2023 05:36

ti-chi-bot mentioned this pull request Dec 19, 2023

statistics: skip auto-analyze when it is executed outside the available time period (#49541) #49577

Merged

13 tasks

hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Jan 31, 2024

This is an automated cherry-pick of pingcap#49541

a74fb63

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 31, 2024

ti-chi-bot bot pushed a commit that referenced this pull request Feb 1, 2024

statistics: skip auto-analyze when it is executed outside the availab…

934a298

…le time period (#49541) (#49577) close #49552

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 26, 2024

This is an automated cherry-pick of pingcap#49541

39fa127

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Mar 26, 2024

statistics: skip auto-analyze when it is executed outside the available time period (#49541) #52097

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 26, 2024

This is an automated cherry-pick of pingcap#49541

1bf7295

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Mar 26, 2024

statistics: skip auto-analyze when it is executed outside the available time period (#49541) #52098

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024

statistics: skip auto-analyze when it is executed outside the availab…

1f6e613

…le time period (#49541) (#52097) close #49552

ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024

statistics: skip auto-analyze when it is executed outside the availab…

c4a9d9b

…le time period (#49541) (#52098) close #49552

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

statistics: skip auto-analyze when it is executed outside the available time period #49541

statistics: skip auto-analyze when it is executed outside the available time period #49541

hawkingrei commented Dec 18, 2023 •

edited

Loading

codecov bot commented Dec 18, 2023 •

edited

Loading

hawkingrei commented Dec 18, 2023

Rustin170506 left a comment

Rustin170506 Dec 19, 2023

hawkingrei Dec 19, 2023

Rustin170506 Dec 19, 2023

hawkingrei Dec 19, 2023

ti-chi-bot bot commented Dec 19, 2023

ti-chi-bot bot commented Dec 19, 2023

time-and-fate commented Dec 19, 2023 •

edited

Loading

hawkingrei commented Dec 19, 2023

hawkingrei commented Dec 19, 2023

ti-chi-bot commented Dec 19, 2023

ti-chi-bot commented Jan 31, 2024

ti-chi-bot commented Jan 31, 2024

ti-chi-bot commented Jan 31, 2024

hawkingrei commented Mar 26, 2024

ti-chi-bot commented Mar 26, 2024

ti-chi-bot commented Mar 26, 2024

statistics: skip auto-analyze when it is executed outside the available time period #49541

statistics: skip auto-analyze when it is executed outside the available time period #49541

Conversation

hawkingrei commented Dec 18, 2023 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

codecov bot commented Dec 18, 2023 • edited Loading

Codecov Report

hawkingrei commented Dec 18, 2023

Rustin170506 left a comment

Choose a reason for hiding this comment

Rustin170506 Dec 19, 2023

Choose a reason for hiding this comment

hawkingrei Dec 19, 2023

Choose a reason for hiding this comment

Rustin170506 Dec 19, 2023

Choose a reason for hiding this comment

hawkingrei Dec 19, 2023

Choose a reason for hiding this comment

ti-chi-bot bot commented Dec 19, 2023

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

time-and-fate commented Dec 19, 2023 • edited Loading

hawkingrei commented Dec 19, 2023

hawkingrei commented Dec 19, 2023

ti-chi-bot commented Dec 19, 2023

ti-chi-bot commented Jan 31, 2024

ti-chi-bot commented Jan 31, 2024

ti-chi-bot commented Jan 31, 2024

hawkingrei commented Mar 26, 2024

ti-chi-bot commented Mar 26, 2024

ti-chi-bot commented Mar 26, 2024

hawkingrei commented Dec 18, 2023 •

edited

Loading

codecov bot commented Dec 18, 2023 •

edited

Loading

time-and-fate commented Dec 19, 2023 •

edited

Loading