-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: delete '.test.bin' files for 'make clean' #49447
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49447 +/- ##
================================================
+ Coverage 70.9865% 71.5614% +0.5749%
================================================
Files 1368 1423 +55
Lines 399849 428067 +28218
================================================
+ Hits 283839 306331 +22492
- Misses 96192 102873 +6681
+ Partials 19818 18863 -955
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PTAL @tiancaiamao @hawkingrei |
@@ -6,7 +6,6 @@ coverage.out | |||
*.iml | |||
*.swp | |||
*.log | |||
*.test.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be retained to avoid unnecessary submissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give me some example about 'submissions'?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #49070
Problem Summary:
What changed and how does it work?
After #30822,
make ut
will build the.test.bin
files for each of the_test.go
file and run them in parallel and clean.test.bin
files. However, whenmake ut
failed because of any reason, the cleanup will not happen and leave a large number of.test.bin
files:IMO it's better to make
.test.bin
files cleanable bymake clean
and remove them from.gitignore
files so that developers will be aware of them(when they're there) and the large amount of size.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.