Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: allow end aborted txn via binary protocal #49384

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Dec 12, 2023

What problem does this PR solve?

Issue Number: close #49151

Problem Summary: When a transaction has been aborted by TTL manager, we cannot commit/rollback it via binary protocal.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2023
Copy link

tiprow bot commented Dec 12, 2023

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #49384 (c1d4023) into master (965ad8a) will decrease coverage by 0.4791%.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49384        +/-   ##
================================================
- Coverage   71.9292%   71.4501%   -0.4791%     
================================================
  Files          1438       1434         -4     
  Lines        345726     436734     +91008     
================================================
+ Hits         248678     312047     +63369     
- Misses        76799     105560     +28761     
+ Partials      20249      19127      -1122     
Flag Coverage Δ
integration 43.8733% <0.0000%> (?)
unit 71.1136% <ø> (-0.8156%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (-2.3466%) ⬇️
parser ∅ <ø> (∅)
br 46.7815% <ø> (-4.8454%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
Copy link

ti-chi-bot bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2024
Copy link

ti-chi-bot bot commented Jan 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 04:24:48.93022913 +0000 UTC m=+1021379.967456059: ☑️ agreed by ekexium.
  • 2024-01-02 08:05:14.213115077 +0000 UTC m=+2157805.250342006: ☑️ agreed by crazycs520.

@zyguan
Copy link
Contributor Author

zyguan commented Jan 3, 2024

/retest-required

Copy link

tiprow bot commented Jan 3, 2024

@zyguan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zyguan
Copy link
Contributor Author

zyguan commented Jan 3, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Jan 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 37c7326 into pingcap:master Jan 3, 2024
18 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #50003.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50004.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #50005.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction cannot be committed/rollbacked via binary protocol after TTL manager timed out
4 participants