Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace exp/maps with std/maps #49315

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 10, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What changed and how does it work?

as the title describes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #49315 (a59b3ee) into master (899dfe8) will increase coverage by 0.9004%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49315        +/-   ##
================================================
+ Coverage   71.0573%   71.9578%   +0.9004%     
================================================
  Files          1368       1408        +40     
  Lines        401992     413948     +11956     
================================================
+ Hits         285645     297868     +12223     
- Misses        96482      97280       +798     
+ Partials      19865      18800      -1065     
Flag Coverage Δ
integration 43.6900% <ø> (?)
unit 71.0573% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.0861% <ø> (-4.8651%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2023
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2023
Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-10 12:51:32.340609571 +0000 UTC m=+187783.377836498: ☑️ agreed by lance6716.
  • 2023-12-11 01:54:26.116209861 +0000 UTC m=+234757.153436773: ☑️ agreed by zimulala.

Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit bcbccaf into pingcap:master Dec 11, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants