Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support setting txn-entry-size-limit by sys var #49237

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Dec 6, 2023

What problem does this PR solve?

Issue Number: close #49236

Problem Summary: allow setting txn-entry-size-limit via system variable.

What changed and how does it work?

Add tidb_txn_entry_size_limit to address the issue.

  • Scope: GLOBAL | SESSION
  • Persists to cluster: Yes
  • Applies to hint SET_VAR: No
  • Data type: Integer
  • Default value: 0 ( disabled, use config by default )
  • Range: 0 to 125829120 (120MiB)
  • Units: byte
  • This variable is used to overwrite txn-entry-size-limit. When setting it in global scope, it also affects internal sessions used by DDL backfilling.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support setting txn-entry-size-limit by system variable.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
Copy link

tiprow bot commented Dec 6, 2023

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #49237 (549f7f9) into master (ecb4783) will increase coverage by 0.6541%.
Report is 15 commits behind head on master.
The diff coverage is 51.5151%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49237        +/-   ##
================================================
+ Coverage   70.9581%   71.6122%   +0.6541%     
================================================
  Files          1368       1428        +60     
  Lines        397092     435191     +38099     
================================================
+ Hits         281769     311650     +29881     
- Misses        95625     104315      +8690     
+ Partials      19698      19226       -472     
Flag Coverage Δ
integration 43.9268% <48.3871%> (?)
unit 71.0683% <100.0000%> (+0.1102%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2043% <ø> (-5.6998%) ⬇️

@cfzjywxk
Copy link
Contributor

/cc
@easonn7 @benmaoer PTAL

Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2023
Copy link

ti-chi-bot bot commented Dec 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-22 11:21:53.880818005 +0000 UTC m=+1219204.918044933: ☑️ agreed by cfzjywxk.
  • 2023-12-25 06:35:23.079516588 +0000 UTC m=+1461214.116743514: ☑️ agreed by crazycs520.

@easonn7
Copy link

easonn7 commented Dec 25, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, easonn7, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 291875a into pingcap:master Dec 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting txn-entry-size-limit by sys var
5 participants