-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support setting txn-entry-size-limit by sys var #49237
Conversation
Signed-off-by: zyguan <[email protected]>
Hi @zyguan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49237 +/- ##
================================================
+ Coverage 70.9581% 71.6122% +0.6541%
================================================
Files 1368 1428 +60
Lines 397092 435191 +38099
================================================
+ Hits 281769 311650 +29881
- Misses 95625 104315 +8690
+ Partials 19698 19226 -472
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: zyguan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520, easonn7, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #49236
Problem Summary: allow setting txn-entry-size-limit via system variable.
What changed and how does it work?
Add
tidb_txn_entry_size_limit
to address the issue.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.