Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: revert "#48905" for release-6.5 #49119

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 4, 2023

This reverts commit b504f0b.

What problem does this PR solve?

Issue Number: close #49098

Problem Summary:

See #49098 for more details.

What changed and how does it work?

See #49098 for more details.

Check List

Tests

  • Unit test

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Dec 4, 2023
@bb7133 bb7133 changed the title Revert "#48905" for release-6.5 server: revert "#48905" for release-6.5 Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@9d6b66a). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49119   +/-   ##
================================================
  Coverage               ?   73.6321%           
================================================
  Files                  ?       1087           
  Lines                  ?     349426           
  Branches               ?          0           
================================================
  Hits                   ?     257290           
  Misses                 ?      75614           
  Partials               ?      16522           

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2023
Copy link

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2023
Copy link

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 04:17:18.838920906 +0000 UTC m=+1414667.504147103: ☑️ agreed by tiancaiamao.
  • 2023-12-04 04:35:12.790760984 +0000 UTC m=+1415741.455987192: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 78d203e into pingcap:release-6.5 Dec 4, 2023
3 checks passed
@bb7133 bb7133 mentioned this pull request Dec 5, 2023
@bb7133 bb7133 deleted the bb7133/revert_32111 branch December 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants