-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "server: Set default drainClientWait as 15s (#42134) (#48944)" #49101
Conversation
…ingcap#48944)" This reverts commit 877198d.
Hi @djshow832. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #49101 +/- ##
================================================
Coverage ? 73.6315%
================================================
Files ? 1087
Lines ? 349436
Branches ? 0
================================================
Hits ? 257295
Misses ? 75621
Partials ? 16520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This reverts commit 877198d.
What problem does this PR solve?
Issue Number: ref #49098
Problem Summary:
#32111 causes too many problems, so we decided to revert it in v6.5.6 and merge #49073 to v6.5.6.
What changed and how does it work?
Revert PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.