Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2257 (#48984) #49064

Merged
merged 3 commits into from
Dec 8, 2023
Merged

util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2257 (#48984) #49064

merged 3 commits into from
Dec 8, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48984

What problem does this PR solve?

Issue Number: close #48983 ref #48181

Problem Summary:

Please see the comments.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 30, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2023
@time-and-fate time-and-fate changed the title util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2254 (#48984) util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2257 (#48984) Dec 5, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2023
@time-and-fate time-and-fate changed the title util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2257 (#48984) util/ranger: don't exclude start key for range from _ in like function (#48984) Dec 5, 2023
@time-and-fate time-and-fate changed the title util/ranger: don't exclude start key for range from _ in like function (#48984) util/ranger: don't exclude start key for range from _ in like function | tidb-test=pr/2257 (#48984) Dec 5, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@ff2fcec). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #49064   +/-   ##
================================================
  Coverage               ?   73.6346%           
================================================
  Files                  ?       1087           
  Lines                  ?     349444           
  Branches               ?          0           
================================================
  Hits                   ?     257312           
  Misses                 ?      75616           
  Partials               ?      16516

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 6, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 6, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-06 03:50:52.967646723 +0000 UTC m=+1585881.632872917: ☑️ agreed by tangenta.
  • 2023-12-06 14:38:16.595884605 +0000 UTC m=+1624725.261110800: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot closed this Dec 8, 2023
@time-and-fate time-and-fate reopened this Dec 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit 66f9635 into pingcap:release-6.5 Dec 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@winoros winoros winoros approved these changes

Assignees

@time-and-fate time-and-fate

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @winoros @tangenta @time-and-fate