Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix index out of range panic of cte when max_chunk_size is samll (#48839) #49003

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48839

What problem does this PR solve?

Issue Number: close #48808

Problem Summary:

  1. CTEExec assume result chunk of child operator will not exceed max_chunk_size. Check builder
  2. Actually row num of chunk will exceeds MaxChunkSize sometimes. Check reuse chunk
  3. So CTEExec may panic here

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@877198d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49003   +/-   ##
================================================
  Coverage               ?   73.6307%           
================================================
  Files                  ?       1087           
  Lines                  ?     349441           
  Branches               ?          0           
================================================
  Hits                   ?     257296           
  Misses                 ?      75625           
  Partials               ?      16520           

Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2023
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2023
Copy link

ti-chi-bot bot commented Dec 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-04 08:34:34.3163817 +0000 UTC m=+1430102.981607890: ☑️ agreed by Defined2014.
  • 2023-12-05 15:31:05.345601314 +0000 UTC m=+1541494.010827509: ☑️ agreed by wshwsh12.

Copy link

ti-chi-bot bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, guo-shaoge, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,guo-shaoge,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guo-shaoge
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit f8de777 into pingcap:release-6.5 Dec 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants