Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Exchange partition, fix LIST COLUMNs validation as well as NULL validation (#46533) #48707

Conversation

YangKeao
Copy link
Member

This is a cherry-pick of the hotfix branch PR #46766. Following is the description copied from #46766


This is an manual cherry-pick of #46533 and #45980

What problem does this PR solve?

Issue Number: close #46492

Problem Summary:
The main issue was that the values are store in single quoted strings, and when adding them to the parser as parameters, they are quoted again, which issues (ignored) internal warnings, and no matching rows will be found.

Also the check did not handle NULL, so I added proper null-safe comparison.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 20, 2023
@YangKeao YangKeao requested review from xhebox and mjonss November 20, 2023 03:47
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 20, 2023
@YangKeao YangKeao requested a review from tiancaiamao November 20, 2023 03:50
@YangKeao
Copy link
Member Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from yangkeao. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:

Well, it told me to ask for approval from myself 😆

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20231120-v6.5.4@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20231120-v6.5.4     #48707   +/-   ##
================================================================
  Coverage                               ?   73.6907%           
================================================================
  Files                                  ?       1084           
  Lines                                  ?     348167           
  Branches                               ?          0           
================================================================
  Hits                                   ?     256567           
  Misses                                 ?      75144           
  Partials                               ?      16456           

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 20, 2023
Copy link

ti-chi-bot bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2023
Copy link

ti-chi-bot bot commented Nov 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-20 04:01:03.809907187 +0000 UTC m=+204092.475133384: ☑️ agreed by xhebox.
  • 2023-11-20 04:47:41.932699494 +0000 UTC m=+206890.597925689: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit 2697958 into pingcap:release-6.5-20231120-v6.5.4 Nov 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants