ddl: use latest PD address to register lightning #48687

lance6716 · 2023-11-17T12:22:34Z

What problem does this PR solve?

Issue Number: close #48680

Problem Summary:

What is changed and how it works?

as title

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <[email protected]>

tiprow · 2023-11-17T12:22:51Z

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2023-11-17T12:26:42Z

pkg/ddl/index.go

 			if variable.EnableDistTask.Load() {
-				_, err = ingest.LitBackCtxMgr.Register(ctx, unique, job.ID, d.etcdCli, job.ReorgMeta.ResourceGroupName)
+				_, err = ingest.LitBackCtxMgr.Register(ctx, unique, job.ID, d.etcdCli, pdLeaderAddr, job.ReorgMeta.ResourceGroupName)
 			} else {
-				_, err = ingest.LitBackCtxMgr.Register(ctx, unique, job.ID, nil, job.ReorgMeta.ResourceGroupName)
+				_, err = ingest.LitBackCtxMgr.Register(ctx, unique, job.ID, nil, pdLeaderAddr, job.ReorgMeta.ResourceGroupName)


Will be removed in #48645

48645 is not block 7.5， we can merge it later.

Signed-off-by: lance6716 <[email protected]>

codecov · 2023-11-17T12:48:41Z

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.7836%. Comparing base (69028f1) to head (b923731).
Report is 2404 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #48687        +/-   ##
================================================
+ Coverage   71.4085%   72.7836%   +1.3750%     
================================================
  Files          1404       1435        +31     
  Lines        407209     414592      +7383     
================================================
+ Hits         290782     301755     +10973     
+ Misses        96471      93883      -2588     
+ Partials      19956      18954      -1002

Flag	Coverage Δ
integration	`43.7635% <0.0000%> (?)`
unit	`71.2206% <59.0909%> (-0.1879%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9874% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.7901% <ø> (-4.2916%)`	⬇️

Benjamin2037

LGTM

Benjamin2037 · 2023-11-17T13:58:59Z

/ok-to-test

ti-chi-bot · 2023-11-17T14:01:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,tangenta]
~~pkg/ddl/OWNERS~~ [Benjamin2037,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-11-17T14:01:55Z

[LGTM Timeline notifier]

Timeline:

2023-11-17 13:25:08.104664992 +0000 UTC m=+4428305.691775122: ☑️ agreed by Benjamin2037.
2023-11-17 14:01:53.925023689 +0000 UTC m=+4430511.512133833: ☑️ agreed by tangenta.

Benjamin2037 · 2023-11-17T14:37:35Z

/restest

Benjamin2037 · 2023-11-17T14:38:24Z

/retest

Signed-off-by: lance6716 <[email protected]>

lance6716 · 2023-11-18T01:25:57Z

/check-issue-triage-complete

ti-chi-bot · 2023-11-18T05:27:14Z

In response to a cherrypick label: new pull request created to branch release-7.5: #48690.

close #48680

lance6716 · 2024-09-09T03:14:29Z

/run-cherry-picker

lance6716 · 2024-09-09T03:15:41Z

/cherry-pick release-6.5

lance6716 · 2024-09-09T03:15:53Z

/cherry-pick release-7.1

ti-chi-bot · 2024-09-09T03:16:26Z

@lance6716: new pull request created to branch release-6.5: #55936.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-09-09T03:16:35Z

@lance6716: new pull request created to branch release-7.1: #55937.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #48680

ddl: use latest PD address to register lightning

9409c48

Signed-off-by: lance6716 <[email protected]>

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2023

ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Nov 17, 2023

ywqzzy reviewed Nov 17, 2023

View reviewed changes

fix lint

a7e723a

Signed-off-by: lance6716 <[email protected]>

Benjamin2037 approved these changes Nov 17, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 17, 2023

Benjamin2037 removed the do-not-merge/needs-tests-checked label Nov 17, 2023

tangenta approved these changes Nov 17, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 17, 2023

fix lint

6d1e966

Signed-off-by: lance6716 <[email protected]>

ti-chi-bot bot added do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Nov 18, 2023

ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Nov 18, 2023

skip mock test to get pd address.

c098e8c

Benjamin2037 force-pushed the fix-1117 branch from 8cc82d3 to c098e8c Compare November 18, 2023 03:00

Benjamin2037 and others added 2 commits November 18, 2023 11:26

lint

a90d27f

fix TestAddIndexIngestLimitOneBackend

b923731

ti-chi-bot bot merged commit 6260e66 into pingcap:master Nov 18, 2023

ti-chi-bot mentioned this pull request Nov 18, 2023

ddl: use latest PD address to register lightning (#48687) #48690

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 18, 2023

ddl: use latest PD address to register lightning (#48687) (#48690)

7181f48

close #48680

tangenta added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 6, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 9, 2024

This is an automated cherry-pick of pingcap#48687

7b80ecd

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Sep 9, 2024

ddl: use latest PD address to register lightning (#48687) #55936

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 9, 2024

This is an automated cherry-pick of pingcap#48687

b40b6ee

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Sep 9, 2024

ddl: use latest PD address to register lightning (#48687) #55937

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 6, 2024

ddl: use latest PD address to register lightning (#48687) (#55937)

bb5d8a8

close #48680

ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024

ddl: use latest PD address to register lightning (#48687) (#55936)

5f4110d

close #48680

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: use latest PD address to register lightning #48687

ddl: use latest PD address to register lightning #48687

lance6716 commented Nov 17, 2023 •

edited

Loading

tiprow bot commented Nov 17, 2023

ywqzzy Nov 17, 2023

Benjamin2037 Nov 17, 2023

codecov bot commented Nov 17, 2023 •

edited

Loading

Benjamin2037 left a comment

Benjamin2037 commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

Benjamin2037 commented Nov 17, 2023

Benjamin2037 commented Nov 17, 2023

lance6716 commented Nov 18, 2023

ti-chi-bot commented Nov 18, 2023

lance6716 commented Sep 9, 2024

lance6716 commented Sep 9, 2024

lance6716 commented Sep 9, 2024

ti-chi-bot commented Sep 9, 2024

ti-chi-bot commented Sep 9, 2024

ddl: use latest PD address to register lightning #48687

ddl: use latest PD address to register lightning #48687

Conversation

lance6716 commented Nov 17, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Nov 17, 2023

ywqzzy Nov 17, 2023

Choose a reason for hiding this comment

Benjamin2037 Nov 17, 2023

Choose a reason for hiding this comment

codecov bot commented Nov 17, 2023 • edited Loading

Codecov Report

Benjamin2037 left a comment

Choose a reason for hiding this comment

Benjamin2037 commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Benjamin2037 commented Nov 17, 2023

Benjamin2037 commented Nov 17, 2023

lance6716 commented Nov 18, 2023

ti-chi-bot commented Nov 18, 2023

lance6716 commented Sep 9, 2024

lance6716 commented Sep 9, 2024

lance6716 commented Sep 9, 2024

ti-chi-bot commented Sep 9, 2024

ti-chi-bot commented Sep 9, 2024

lance6716 commented Nov 17, 2023 •

edited

Loading

codecov bot commented Nov 17, 2023 •

edited

Loading