Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix index merge union case couldn't sink limit into index merge reader #48590

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #48588

Problem Summary:

What is changed and how it works?

detail ref the comment #48588 (comment) in the issue above

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix index merge union case couldn't sink limit into index merge reader

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
Copy link

tiprow bot commented Nov 14, 2023

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #48590 (b25c240) into master (4793a04) will increase coverage by 1.6850%.
Report is 16 commits behind head on master.
The diff coverage is 71.4285%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48590        +/-   ##
================================================
+ Coverage   71.4227%   73.1078%   +1.6850%     
================================================
  Files          1404       1428        +24     
  Lines        407209     415854      +8645     
================================================
+ Hits         290840     304022     +13182     
+ Misses        96403      92955      -3448     
+ Partials      19966      18877      -1089     
Flag Coverage Δ
integration 44.1905% <71.4285%> (?)
unit 71.6961% <71.4285%> (+0.2733%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8241% <ø> (-4.2517%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@AilinKid AilinKid force-pushed the fix-index-merge-union-case-downgrade-from-7.3-to-7.4 branch from 60bc931 to 60f2ca0 Compare November 14, 2023 11:34
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2023
Copy link

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2023
Copy link

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-14 11:36:09.84010237 +0000 UTC m=+4162567.427212514: ☑️ agreed by winoros.
  • 2023-11-15 06:19:33.275696056 +0000 UTC m=+4229970.862806186: ☑️ agreed by qw4990.

@AilinKid
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 15, 2023
@AilinKid
Copy link
Contributor Author

/retest

@AilinKid
Copy link
Contributor Author

/retest-required

Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 15, 2023
@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Nov 15, 2023

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Nov 16, 2023

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48632.

ti-chi-bot bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: regression index merge UNION case from v7.3.0 to v7.4.0 and master
5 participants