Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Add cast as json push down support for tiflash #48550

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Nov 13, 2023

What problem does this PR solve?

Issue Number: close #48551

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2023
Copy link

tiprow bot commented Nov 13, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 13, 2023

/hold
wait for pingcap/tiflash#8333

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@SeaRise SeaRise mentioned this pull request Nov 13, 2023
12 tasks
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #48550 (3b3e662) into master (ccbd1b5) will decrease coverage by 17.5159%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #48550         +/-   ##
=================================================
- Coverage   70.9774%   53.4615%   -17.5159%     
=================================================
  Files          1368       1585        +217     
  Lines        405013     596924     +191911     
=================================================
+ Hits         287468     319125      +31657     
- Misses        97528     255317     +157789     
- Partials      20017      22482       +2465     
Flag Coverage Δ
integration 35.0025% <0.0000%> (?)
unit 70.9679% <100.0000%> (-0.0095%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 55.3003% <ø> (+2.2464%) ⬆️

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 27, 2023

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 27, 2023

/cc @windtalker @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from windtalker and XuHuaiyu November 27, 2023 08:59
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

pkg/expression/expr_to_pb_test.go Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 09:02:28.780377394 +0000 UTC m=+826977.445603574: ☑️ agreed by XuHuaiyu.
  • 2023-11-28 00:19:37.808178867 +0000 UTC m=+882006.473405061: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit d0feede into pingcap:master Nov 28, 2023
15 checks passed
@SeaRise SeaRise deleted the support_cast_as_json branch November 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cast as json push down support for tiflash
3 participants