Support date_sub function #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add date_sub operation test
|
What does Cast mean? |
|
here means calculation |
|
cast is not for calculation, it means conversation. |
|
It has calculated the meanings in the dictionary, here it may not be an appropriate name. Do you have a suggestion? |
|
DateArith or DateArithmetic |
|
gotcha, |
| @@ -2285,12 +2286,22 @@ FunctionCallNonKeyword: | |||
| } | |||
| | "DATE_ADD" '(' Expression ',' "INTERVAL" Expression TimeUnit ')' | |||
| { | |||
| $$ = &expression.DateAdd{ | |||
| $$ = &expression.DateArith{ | |||
| Op:"ADD", | |||
There was a problem hiding this comment.
use a const int value instead of string, like
const (
DateAdd
DateSub
)
|
PTAL |
| const ( | ||
| // DateAdd is to run date_add function option. | ||
| // See: https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_date-add | ||
| DateAdd = 1 |
There was a problem hiding this comment.
I prefer to use iota, like
type xxxType byte
const (
DateAdd xxxType = iota +1
DateSub
)
There was a problem hiding this comment.
+1
Btw, you can implement String() for DateArithType.
|
PTAL @siddontang |
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* wait sub task finish before exit * add a comment
nolouch
pushed a commit
to nolouch/tidb
that referenced
this pull request
Jul 21, 2023
* add gc black list Signed-off-by: ystaticy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#419