Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: disable tidb_read_staleness for SET_VAR hint #48477

Merged

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 9, 2023

What problem does this PR solve?

Issue Number: close #48478

Problem Summary:

What is changed and how it works?

This variable takes effect at the planner's preprocess phase. But we build SET_VAR hint just before we parse the AST node.

We disable it first to make the behavior consistent.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros winoros added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2023
@winoros winoros force-pushed the disable-read-staleness-for-setvar branch from b11454f to 3706c18 Compare November 9, 2023 09:15
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2023
@winoros winoros removed the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-linked-issue labels Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #48477 (3706c18) into master (3956421) will increase coverage by 1.5575%.
Report is 31 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48477        +/-   ##
================================================
+ Coverage   71.3861%   72.9436%   +1.5575%     
================================================
  Files          1402       1427        +25     
  Lines        406824     414716      +7892     
================================================
+ Hits         290416     302509     +12093     
+ Misses        96474      93278      -3196     
+ Partials      19934      18929      -1005     
Flag Coverage Δ
integration 43.3479% <ø> (?)
unit 71.5607% <ø> (+0.1745%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8773% <ø> (-4.0736%) ⬇️

Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 09:24:06.113684993 +0000 UTC m=+3722643.700795138: ☑️ agreed by AilinKid.
  • 2023-11-09 10:28:11.722992233 +0000 UTC m=+3726489.310102373: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 151b5b1 into pingcap:master Nov 9, 2023
15 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable tidb_read_staleness for SET_VAR
4 participants