-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable: disable tidb_read_staleness for SET_VAR hint #48477
variable: disable tidb_read_staleness for SET_VAR hint #48477
Conversation
b11454f
to
3706c18
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48477 +/- ##
================================================
+ Coverage 71.3861% 72.9436% +1.5575%
================================================
Files 1402 1427 +25
Lines 406824 414716 +7892
================================================
+ Hits 290416 302509 +12093
+ Misses 96474 93278 -3196
+ Partials 19934 18929 -1005
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #48478
Problem Summary:
What is changed and how it works?
This variable takes effect at the planner's preprocess phase. But we build SET_VAR hint just before we parse the AST node.
We disable it first to make the behavior consistent.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.