Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, CTE: Fix default inline CTE which contains agg or window function and refactor inline CTE strategy | tidb-test=pr/2240 #48437

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48188

What problem does this PR solve?

Issue Number: close #47711
close #47603

Problem Summary:

What is changed and how it works?

  1. Forbidden CTE inline when it contains or indirectly contains agg or window and is referenced by recursive part of CTE.
  2. The fake recursive CTE can be identified and judged as non-recursive CTE. (mark as recursive but query has no recursive part)
  3. Refactor the CTE inline strategy

Refactor
Unified inline strategy logic in CTE used.

  1. preprocessor and buildCTE() : collect CTE info such as consumerCount, forceInlineByHintOrVar, containAggOrWindow
  2. tryBuildCTE() : Combine the declaration of CTE and the use of CTE to jointly determine whether a CTE can be inlined.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

1. with in setoprselectlist should be record in ctestack
2. the fake recursive cte also can be inlined. such as mark as recursive but has no recursive part in query
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 8, 2023
@elsa0520
Copy link
Contributor

elsa0520 commented Nov 8, 2023

/test mysql-test tidb-test=pr/2240

Copy link

tiprow bot commented Nov 8, 2023

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test tidb-test=pr/2240

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 9, 2023
@elsa0520
Copy link
Contributor

elsa0520 commented Nov 9, 2023

/retitle planner, CTE: Fix default inline CTE which contains agg or window function and refactor inline CTE strategy | tidb-test=pr/2240

@ti-chi-bot ti-chi-bot bot changed the title planner, CTE: Fix default inline CTE which contains agg or window function and refactor inline CTE strategy | tidb-test=pr/2239 (#48188) planner, CTE: Fix default inline CTE which contains agg or window function and refactor inline CTE strategy | tidb-test=pr/2240 Nov 9, 2023
@elsa0520
Copy link
Contributor

elsa0520 commented Nov 9, 2023

/test mysql-test

Copy link

tiprow bot commented Nov 9, 2023

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-09 03:19:18.769976803 +0000 UTC m=+3700756.357086948: ☑️ agreed by time-and-fate.
  • 2023-11-09 03:24:17.852095982 +0000 UTC m=+3701055.439206124: ☑️ agreed by qw4990.

@elsa0520
Copy link
Contributor

elsa0520 commented Nov 9, 2023

/test build

Copy link

tiprow bot commented Nov 9, 2023

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit cf0a91c into pingcap:release-7.5 Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants