-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade go1.21.4 #48373
*: upgrade go1.21.4 #48373
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
@bb7133 PTAL |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48373 +/- ##
================================================
+ Coverage 71.3791% 73.3216% +1.9425%
================================================
Files 1402 1425 +23
Lines 406780 418276 +11496
================================================
+ Hits 290356 306687 +16331
+ Misses 96504 92769 -3735
+ Partials 19920 18820 -1100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
|
I think you should carefully consider why many errors only occur on your end and not on tiprow? |
[LGTM Timeline notifier]Timeline:
|
/hold @bb7133 The control of merging is now in your hands. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, Defined2014, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What problem does this PR solve?
Issue Number: close #48383
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.