-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) #48103
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) #48103
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
a698876
to
98f0baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48103 +/- ##
================================================
Coverage ? 73.6524%
================================================
Files ? 1085
Lines ? 348799
Branches ? 0
================================================
Hits ? 256899
Misses ? 75421
Partials ? 16479 |
This is an automated cherry-pick of #48090
What problem does this PR solve?
Issue Number: close #48082
Problem Summary:
What is changed and how it works?
Reuse chunk for GetMatchedRowsAndPtrs.
Add a new benchmark case.
Check List
Tests
BenchmarkHashJoinExec
Profile for the new case: left is the master, right is this pr.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.