*: support write slow query log into seperate files #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix CI. |
zimulala
reviewed
Oct 19, 2017
| @@ -37,6 +37,9 @@ format = "text" | |||
| # Disable automatic timestamps in output | |||
| disable-timestamp = false | |||
|
|
|||
| # Stores slow query log into seperate files. | |||
| #slow-query-file = "" | |||
There was a problem hiding this comment.
We should not set it by default, merge the output of slow query to standard log will be helpful for debugging.
|
Add a unit test for |
winkyao
reviewed
Oct 20, 2017
|
|
LGTM |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Oct 22, 2017
shenli
pushed a commit
that referenced
this pull request
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support this config option, then slow query log will be redirect to the separate files:
This PR also remove
pd/pkg/logutiland create atidb/util/logutilpackage, because log config in Pd is somehow different with TiDB. For example, TiDB doesn't need to handle etcd log, while Pd doesn't need to collect slow query log.Using
slow_query_logandslow_query_log_fileSQL variable to control the slow query log is not supported deliberately, because global session variable will change all TiDB instance's behavior, the deploy environment of the instances maybe diverse, however.