Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add int1, int2, int3, int4, int8 type support #4803

Merged
merged 3 commits into from
Oct 17, 2017
Merged

parser: add int1, int2, int3, int4, int8 type support #4803

merged 3 commits into from
Oct 17, 2017

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Oct 17, 2017

fix #4740

@hanfei1991
Copy link
Member

LGTM

@winkyao winkyao added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2017
winoros
winoros approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2017
@winkyao winkyao merged commit d5a2690 into master Oct 17, 2017
@winkyao winkyao deleted the winkyao/fix_issue_4740 branch October 17, 2017 08:15
@shenli
Copy link
Member

shenli commented Oct 17, 2017

@winkyao Please update the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type int1, int2, int3, int4, int8 syntax support.
4 participants
@winkyao @hanfei1991 @shenli @winoros