-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistic: fix panic when building topN (#47928) #47989
statistic: fix panic when building topN (#47928) #47989
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47989 +/- ##
================================================
Coverage ? 73.7357%
================================================
Files ? 1085
Lines ? 349414
Branches ? 0
================================================
Hits ? 257643
Misses ? 75311
Partials ? 16460 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #47928
Signed-off-by: hi-rustin [email protected]
What problem does this PR solve?
Issue Number: close #35948
Problem Summary:
What is changed and how it works?
The issue arises when a value appears twice in the topN list, triggering a panic. The solution involves breaking out of the loop as soon as we find the duplicate value. This bug seems to occur only when the column is of JSON type. Since we haven't been able to reproduce the issue, we've added a warning log to print all topN values, helping us identify the duplicated value.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.