Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistic: fix panic when building topN (#47928) #47989

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47928

Signed-off-by: hi-rustin [email protected]

What problem does this PR solve?

Issue Number: close #35948

Problem Summary:

What is changed and how it works?

The issue arises when a value appears twice in the topN list, triggering a panic. The solution involves breaking out of the loop as soon as we find the duplicate value. This bug seems to occur only when the column is of JSON type. Since we haven't been able to reproduce the issue, we've added a warning log to print all topN values, helping us identify the duplicated value.

Check List

Tests

  • Unit test
  • Integration test
  • We will test it on users env.
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused a panic while generating the topN statistics

@ti-chi-bot ti-chi-bot added component/statistics release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 25, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 31, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@de507fc). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #47989   +/-   ##
================================================
  Coverage               ?   73.7357%           
================================================
  Files                  ?       1085           
  Lines                  ?     349414           
  Branches               ?          0           
================================================
  Hits                   ?     257643           
  Misses                 ?      75311           
  Partials               ?      16460           

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-31 05:38:55.603904572 +0000 UTC m=+2931533.191014732: ☑️ agreed by hi-rustin.
  • 2023-10-31 09:14:03.63985083 +0000 UTC m=+2944441.226960978: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 7a0b606 into pingcap:release-6.5 Oct 31, 2023
3 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the cherry-pick-47928-to-release-6.5 branch December 26, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/statistics lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants