types, stmtctx, *: use ZeroDate, ZeroInDate and InvalidDate related flags to replace variable in statement context #47794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
added
the
release-note-none
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
size/XXL
|
/check-issue-triage-complete |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47794 +/- ##
================================================
+ Coverage 71.7365% 72.9870% +1.2505%
================================================
Files 1401 1424 +23
Lines 405704 413528 +7824
================================================
+ Hits 291038 301822 +10784
+ Misses 94917 92843 -2074
+ Partials 19749 18863 -886
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YangKeao
force-pushed
the
fix-47508
branch
3 times, most recently
from
9c03d83 to
0983af6
Compare
|
/retest |
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
fix-47508
branch
2 times, most recently
from
cdc8e4d to
d794f57
Compare
YangKeao
commented
Oct 23, 2023
YangKeao
force-pushed
the
fix-47508
branch
2 times, most recently
from
50c65f8 to
c26c4f2
Compare
Signed-off-by: Yang Keao <[email protected]>
|
/retest |
xhebox
approved these changes
Oct 23, 2023
Signed-off-by: Yang Keao <[email protected]>
lcwangchao
approved these changes
Oct 25, 2023
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <[email protected]>
YangKeao
requested review from
BornChanger,
3pointer and
D3Hunter
and removed request for
BornChanger
3pointer
approved these changes
Oct 26, 2023
D3Hunter
approved these changes
Oct 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, D3Hunter, lcwangchao, xhebox, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47508, close #47507
Problem Summary:
This PR replaces the field
NoZeroDate,IgnoreZeroInDateandAllowInvalidDateto the flag in types context.Check List
Tests
They are all covered by existing tests