*: update tikv/client-go to fix batch-client send loop panic issue #47716

crazycs520 · 2023-10-17T09:03:26Z

What problem does this PR solve?

Issue Number: close #47691

related PR: tikv/client-go#1021

Problem Summary: update tikv/client-go to fix batch-client send loop panic issue

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Side effects
Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

N/A

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <[email protected]>

tiprow · 2023-10-17T09:03:48Z

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-10-17T09:13:12Z

Codecov Report

Merging #47716 (b5b720e) into master (d0a5bc5) will increase coverage by 0.8979%.
Report is 71 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47716        +/-   ##
================================================
+ Coverage   71.9075%   72.8055%   +0.8979%     
================================================
  Files          1398       1423        +25     
  Lines        405084     416081     +10997     
================================================
+ Hits         291286     302930     +11644     
- Misses        94200      94208         +8     
+ Partials      19598      18943       -655

Flag	Coverage Δ
integration	`41.3909% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.6660% <ø> (-4.2891%)`	⬇️

Signed-off-by: crazycs520 <[email protected]>

crazycs520 · 2023-10-17T10:56:25Z

/retest-required

tiprow · 2023-10-17T10:56:59Z

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crazycs520 · 2023-10-17T10:59:19Z

/ok-to-test

zimulala · 2023-10-18T02:46:17Z

tests/realtikvtest/sessiontest/session_fail_test.go

+					session.ResultSetToStringSlice(ctx, tk.Session(), rs)
+				}
+			}
+


Please remove this useless line.
Besides, I ran this test（with --with-real-tikv and -race） locally with the master version 2 twice and passed both times. Is this test unreliable or does it need to work well on CI?

Nice catch. I wrote this test in the release-6.5 branch first time, and the test will fail in release-6.5 branch.

Master branch can pass the test even without tikv/client-go#1021 , I still keep the test to detect data race in future.

In release-6.5 run this test will fail.

github.com/pingcap/tidb release-6.5 ✗ ▶ cd tests/realtikvtest/sessiontest/ tests/realtikvtest/sessiontest release-6.5 ✗ ▶ go test -race --tags=intest -run=TestBatchClientDataRace --with-real-tikv=true ... ... ... [2023/10/18 14:56:15.607 +08:00] [INFO] [pd.go:209] ["closed pd http client"] --- FAIL: TestBatchClientDataRace (31.54s) testing.go:1465: race detected during execution of test FAIL exit status 1 FAIL github.com/pingcap/tidb/tests/realtikvtest/sessiontest 32.724s

Signed-off-by: crazycs520 <[email protected]>

zimulala

LGTM

Signed-off-by: crazycs520 <[email protected]>

…47716) (#47745) close #47691

ti-chi-bot · 2023-10-18T08:28:26Z

@crazycs520: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/unit-test	`b5b720e`	link	true	`/test unit-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiprow · 2023-10-18T08:31:21Z

@crazycs520: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`b5b720e`	link	true	`/test tiprow_fast_test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2023-10-18T09:50:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-10-18T09:50:22Z

[LGTM Timeline notifier]

Timeline:

2023-10-18 06:54:07.884661804 +0000 UTC m=+1812845.471771949: ☑️ agreed by zimulala.
2023-10-18 09:50:21.8702728 +0000 UTC m=+1823419.457382930: ☑️ agreed by nolouch.

cfzjywxk · 2023-10-27T07:27:17Z

@crazycs520
Is it already picked to the release-7.5 branch? If not we need to pick the fix to release-7.5 it's a blocking issue.

crazycs520 · 2023-10-31T09:29:05Z

#48109 already updated the go.mod.

seiya-annie · 2024-06-13T10:13:23Z

/found community

crazycs520 added 2 commits October 17, 2023 16:48

init

03aabee

Signed-off-by: crazycs520 <[email protected]>

*: update tikv/client-go to fix batch-client send loop panic issue

95f4f6e

Signed-off-by: crazycs520 <[email protected]>

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023

make bazel_prepare

2dec85a

Signed-off-by: crazycs520 <[email protected]>

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 17, 2023

zimulala reviewed Oct 18, 2023

View reviewed changes

address comment

29e50b1

Signed-off-by: crazycs520 <[email protected]>

zimulala approved these changes Oct 18, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023

crazycs520 added 2 commits October 18, 2023 15:11

refine test

2f2c554

Signed-off-by: crazycs520 <[email protected]>

refine test

8aa4cf6

Signed-off-by: crazycs520 <[email protected]>

crazycs520 mentioned this pull request Oct 18, 2023

*: update tikv/client-go to fix batch-client send loop panic issue (#47716) #47745

Merged

5 tasks

fix test

b5b720e

Signed-off-by: crazycs520 <[email protected]>

ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023

*: update tikv/client-go to fix batch-client send loop panic issue (#…

536545d

…47716) (#47745) close #47691

nolouch approved these changes Oct 18, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2023

crazycs520 closed this Oct 31, 2023

ti-chi-bot bot added the report/community The community has encountered this bug. label Jun 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: update tikv/client-go to fix batch-client send loop panic issue #47716

*: update tikv/client-go to fix batch-client send loop panic issue #47716

crazycs520 commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

codecov bot commented Oct 17, 2023 •

edited

Loading

crazycs520 commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

crazycs520 commented Oct 17, 2023

zimulala Oct 18, 2023

crazycs520 Oct 18, 2023

crazycs520 Oct 18, 2023 •

edited

Loading

zimulala left a comment

ti-chi-bot bot commented Oct 18, 2023 •

edited

Loading

tiprow bot commented Oct 18, 2023

ti-chi-bot bot commented Oct 18, 2023

ti-chi-bot bot commented Oct 18, 2023

cfzjywxk commented Oct 27, 2023

crazycs520 commented Oct 31, 2023

seiya-annie commented Jun 13, 2024

*: update tikv/client-go to fix batch-client send loop panic issue #47716

*: update tikv/client-go to fix batch-client send loop panic issue #47716

Conversation

crazycs520 commented Oct 17, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Oct 17, 2023

codecov bot commented Oct 17, 2023 • edited Loading

Codecov Report

crazycs520 commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

crazycs520 commented Oct 17, 2023

zimulala Oct 18, 2023

Choose a reason for hiding this comment

crazycs520 Oct 18, 2023

Choose a reason for hiding this comment

crazycs520 Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 18, 2023 • edited Loading

tiprow bot commented Oct 18, 2023

ti-chi-bot bot commented Oct 18, 2023

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

cfzjywxk commented Oct 27, 2023

crazycs520 commented Oct 31, 2023

seiya-annie commented Jun 13, 2024

codecov bot commented Oct 17, 2023 •

edited

Loading

crazycs520 Oct 18, 2023 •

edited

Loading

ti-chi-bot bot commented Oct 18, 2023 •

edited

Loading