importinto: add more logs to external backend, disable parallel sort #47680

D3Hunter · 2023-10-16T16:32:00Z

What problem does this PR solve?

Issue Number: ref #47572

Problem Summary:

What is changed and how it works?

add more logs to external backend, disable parallel sort to speed up encode&sort

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

with a case of 150g, import takes 58m after vs 70m before, mainly speed up encode&sort step. and CPU curve became more smooth.
after

before

flush log looks like this:

[2023/10/16 16:27:57.768 +00:00] [INFO] [writer.go:445] ["flush kv"] [bytes=268339017] [kv-cnt=18160] [stat-size=42504] [sort-time=250.47596ms] [write-time=1.781394854s] [sort-speed(kv/s)=72.5kB] [write-speed(bytes/s)=143.7MiB] [writerID=data/56625710-9837-4c0e-a3f1-b35490f9a008]
[2023/10/16 16:27:57.963 +00:00] [INFO] [writer.go:445] ["flush kv"] [bytes=268339452] [kv-cnt=18160] [stat-size=42504] [sort-time=53.950553ms] [write-time=1.635531465s] [sort-speed(kv/s)=336.6kB] [write-speed(bytes/s)=156.5MiB] [writerID=data/22a1c4ea-b6aa-4a39-9896-b4a461578107]

No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-10-16T16:32:24Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-10-16T16:46:25Z

Codecov Report

Merging #47680 (5d5b3f1) into master (5ac13d9) will increase coverage by 0.9072%.
Report is 1 commits behind head on master.
The diff coverage is 72.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47680        +/-   ##
================================================
+ Coverage   71.8864%   72.7936%   +0.9072%     
================================================
  Files          1398       1421        +23     
  Lines        405057     411459      +6402     
================================================
+ Hits         291181     299516      +8335     
+ Misses        94266      93097      -1169     
+ Partials      19610      18846       -764

Flag	Coverage Δ
integration	`41.3432% <0.0000%> (?)`
unit	`71.8897% <72.0000%> (+0.0033%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.6969% <75.0000%> (-4.2216%)`	⬇️

D3Hunter · 2023-10-17T02:16:02Z

/retest

tiprow · 2023-10-17T02:16:34Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-10-17T03:02:05Z

/retest

tiprow · 2023-10-17T03:02:43Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-10-17T04:06:57Z

br/pkg/lightning/backend/external/writer.go

@@ -474,7 +505,6 @@ func (w *Writer) flushKVs(ctx context.Context, fromClose bool) (err error) {
 	w.writeBatch = w.writeBatch[:0]
 	w.rc.reset()
 	w.kvBuffer.Reset()
-	savedBytes = w.batchSize


moved to above in another pr, this can be deleted

ti-chi-bot · 2023-10-17T04:11:44Z

[LGTM Timeline notifier]

Timeline:

2023-10-17 02:29:03.578270612 +0000 UTC m=+1710541.165380760: ☑️ agreed by tangenta.
2023-10-17 04:11:43.281921275 +0000 UTC m=+1716700.869031405: ☑️ agreed by ywqzzy.

D3Hunter · 2023-10-17T04:39:26Z

/retest

tiprow · 2023-10-17T04:39:58Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-10-17T05:48:32Z

/approve

ti-chi-bot · 2023-10-17T05:48:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,tangenta]
~~br/pkg/lightning/OWNERS~~ [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2023-10-17T05:52:12Z

/retest

tiprow · 2023-10-17T05:52:43Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

D3Hunter · 2023-10-17T06:59:19Z

will cp to 7.5 when #47485 cp, else there might be conflict

D3Hunter · 2023-10-17T09:41:31Z

/cherry-pick release-7.5

ti-chi-bot · 2023-10-17T09:42:14Z

@D3Hunter: new pull request created to branch release-7.5: #47719.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…ingcap#47680) ref pingcap#47572

…47680) (#47719) ref #47572

…ingcap#47680) ref pingcap#47572

D3Hunter added 3 commits October 17, 2023 00:22

log and use single thread sort

9f2f006

log writer id

fde96b1

change

d9426e2

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2023

tangenta approved these changes Oct 17, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 17, 2023

Merge remote-tracking branch 'upstream/master' into writer-log

5d5b3f1

D3Hunter commented Oct 17, 2023

View reviewed changes

ywqzzy approved these changes Oct 17, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023

ti-chi-bot bot added the approved label Oct 17, 2023

ti-chi-bot bot merged commit 1978479 into pingcap:master Oct 17, 2023
8 checks passed

D3Hunter deleted the writer-log branch October 17, 2023 06:51

ti-chi-bot mentioned this pull request Oct 17, 2023

importinto: add more logs to external backend, disable parallel sort (#47680) #47719

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 17, 2023

importinto: add more logs to external backend, disable parallel sort (p…

5cf9476

…ingcap#47680) ref pingcap#47572

ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023

importinto: add more logs to external backend, disable parallel sort (#…

ffe13ab

…47680) (#47719) ref #47572

wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024

importinto: add more logs to external backend, disable parallel sort (p…

413d1a7

…ingcap#47680) ref pingcap#47572

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

importinto: add more logs to external backend, disable parallel sort #47680

importinto: add more logs to external backend, disable parallel sort #47680

D3Hunter commented Oct 16, 2023

tiprow bot commented Oct 16, 2023

codecov bot commented Oct 16, 2023 •

edited

Loading

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter Oct 17, 2023 •

edited

Loading

ti-chi-bot bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

ti-chi-bot commented Oct 17, 2023

importinto: add more logs to external backend, disable parallel sort #47680

importinto: add more logs to external backend, disable parallel sort #47680

Conversation

D3Hunter commented Oct 16, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Oct 16, 2023

codecov bot commented Oct 16, 2023 • edited Loading

Codecov Report

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

ti-chi-bot bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

tiprow bot commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

D3Hunter commented Oct 17, 2023

ti-chi-bot commented Oct 17, 2023

codecov bot commented Oct 16, 2023 •

edited

Loading

D3Hunter Oct 17, 2023 •

edited

Loading