-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importinto: revert "use one writer for each kv group for all concurrent encoder" #47666
Conversation
…nt encoder (pingcap#47185)" This reverts commit 4e82952.
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47666 +/- ##
================================================
+ Coverage 71.9282% 72.9425% +1.0142%
================================================
Files 1396 1419 +23
Lines 404781 412600 +7819
================================================
+ Hits 291152 300961 +9809
+ Misses 94027 92789 -1238
+ Partials 19602 18850 -752
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
This reverts pr #47185, using 1 writer for a kv group for all encode routine, will mix kvs(such as data) in different chunk into one sorted kv file, when write to tikv, external engine might switch from 1 file to another frequently as the ordered kvs might store in different files, and only a small part of it is continuous in one file, it causes import speed extremely slow
Issue Number: ref #46704, #47572
Problem Summary:
What is changed and how it works?
Check List
Tests
this pr only revert another pr, so existing test should be enough, we only do a simple manual test here:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.