Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: revert "use one writer for each kv group for all concurrent encoder" #47666

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Oct 16, 2023

What problem does this PR solve?

This reverts pr #47185, using 1 writer for a kv group for all encode routine, will mix kvs(such as data) in different chunk into one sorted kv file, when write to tikv, external engine might switch from 1 file to another frequently as the ordered kvs might store in different files, and only a small part of it is continuous in one file, it causes import speed extremely slow

image

Issue Number: ref #46704, #47572

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    this pr only revert another pr, so existing test should be enough, we only do a simple manual test here:
  • import with global sort, should work. for a case of 150g, takes 70m after vs 461m before
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2023
@tiprow
Copy link

tiprow bot commented Oct 16, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Oct 16, 2023

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #47666 (1b7436e) into master (eafb78a) will increase coverage by 1.0142%.
Report is 10 commits behind head on master.
The diff coverage is 9.8039%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47666        +/-   ##
================================================
+ Coverage   71.9282%   72.9425%   +1.0142%     
================================================
  Files          1396       1419        +23     
  Lines        404781     412600      +7819     
================================================
+ Hits         291152     300961      +9809     
+ Misses        94027      92789      -1238     
+ Partials      19602      18850       -752     
Flag Coverage Δ
integration 41.5876% <0.0000%> (?)
unit 72.0445% <9.8039%> (+0.1162%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7484% <ø> (-4.1818%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 10:01:00.491009056 +0000 UTC m=+1651258.078119201: ☑️ agreed by wjhuang2016.
  • 2023-10-16 11:00:13.455858653 +0000 UTC m=+1654811.042968798: ☑️ agreed by lance6716.

@D3Hunter
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ab4c20b into pingcap:master Oct 16, 2023
16 of 20 checks passed
@D3Hunter D3Hunter deleted the revert-single-writer branch October 16, 2023 15:08
wuhuizuo pushed a commit to wuhuizuo/tidb that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants