Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: some builtin functions can be folded #4756

Merged
merged 6 commits into from
Oct 12, 2017
Merged

expression: some builtin functions can be folded #4756

merged 6 commits into from
Oct 12, 2017

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Oct 12, 2017 •
edited
Loading

  • sysdate
  • curdate
  • current_date
  • utc_date
  • utc_timestamp
  • unix_timestamp
  • database
  • current_user
  • user
  • connection_id
  • last_insert_id
  • version

@coocood
Copy link
Member

coocood commented Oct 12, 2017

What about utc_date, curdate, etc?

@zz-jason zz-jason changed the title expression: unix_timestamp, utc_timestamp can be folded expression: some builtin functions can be folded Oct 12, 2017
@zz-jason
Copy link
Member Author

/run-all-test

@zz-jason
Copy link
Member Author

@coocood @XuHuaiyu PTAL

@XuHuaiyu
Copy link
Contributor

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2017
@coocood
Copy link
Member

coocood commented Oct 12, 2017

LGTM

@coocood coocood merged commit e488bcc into master Oct 12, 2017
@coocood coocood deleted the zz-jason/expression/foldable branch October 12, 2017 06:18
@alivxxx alivxxx mentioned this pull request Sep 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @coocood @XuHuaiyu