snapshot_backup: deny executing tidb-lightning import while running snapshot_backup (#47001) #47341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
ok-to-test
4 tasks
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
BornChanger
approved these changes
Sep 28, 2023
ti-chi-bot
added
the
cherry-pick-approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47341 +/- ##
================================================
Coverage ? 73.6824%
================================================
Files ? 1085
Lines ? 348395
Branches ? 0
================================================
Hits ? 256706
Misses ? 75228
Partials ? 16461 |
3pointer
approved these changes
Sep 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
BornChanger
pushed a commit
to BornChanger/tidb
that referenced
this pull request
Sep 28, 2023
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Sep 29, 2023
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…napshot_backup (pingcap#47001) (pingcap#47341) (pingcap#20) ref pingcap#46850 Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47001
What problem does this PR solve?
Issue Number: ref #46850
Problem Summary:
See the issue.
What is changed and how it works?
A new RPC named "DenyImprotRpcs" has been added to TiKV, which allows us deny importing during backing up.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.