Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privilege/privileges: fix show grants display empty entries #4734

Merged
merged 2 commits into from
Oct 11, 2017
Merged

privilege/privileges: fix show grants display empty entries #4734

merged 2 commits into from
Oct 11, 2017

Conversation

tiancaiamao
Copy link
Contributor

If we revoke after grant some privilege, show grants display some wrong results:

GRANT ALL PRIVILEGES ON `te%`.* TO 'show'@'localhost'
REVOKE ALL PRIVILEGES ON `te%`.* FROM 'show'@'localhost'
SHOW GRANTS FOR 'show'@'localhost'

should get nothing, but get

GRANT ON `te%`.* TO 'show'@'localhost'

@shenli
Copy link
Member

shenli commented Oct 11, 2017

LGTM

@shenli
Copy link
Member

shenli commented Oct 11, 2017

/run-all-tests

zz-jason
zz-jason approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 2eab78f into master Oct 11, 2017
@coocood coocood deleted the tiancaiamao/show-grants-display branch October 11, 2017 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @shenli @zz-jason @coocood