-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move IT tests in sessionctx
, sessiontxn
to integrationtest
#47212
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47212 +/- ##
================================================
- Coverage 72.9862% 72.6854% -0.3008%
================================================
Files 1340 1361 +21
Lines 400251 406549 +6298
================================================
+ Hits 292128 295502 +3374
- Misses 89191 92241 +3050
+ Partials 18932 18806 -126
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sessionctx
, sessiontxn
to integrationtest
/check-issue-triage-complete |
/test mysql-test |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
sessionctx
, sessiontxn
to integrationtestsessionctx
, sessiontxn
to integrationtest
What problem does this PR solve?
Issue Number: close #47211, close #47213
Problem Summary: Only move 3 + 4 test cases. Others are related with binlog,
show states
, failpoint etc.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.