Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move IT tests in sessionctx, sessiontxn to integrationtest #47212

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 24, 2023

What problem does this PR solve?

Issue Number: close #47211, close #47213

Problem Summary: Only move 3 + 4 test cases. Others are related with binlog, show states, failpoint etc.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 requested a review from a team as a code owner September 24, 2023 07:46
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2023
@tiprow
Copy link

tiprow bot commented Sep 24, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #47212 (3f820eb) into master (34438f8) will decrease coverage by 0.3008%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47212        +/-   ##
================================================
- Coverage   72.9862%   72.6854%   -0.3008%     
================================================
  Files          1340       1361        +21     
  Lines        400251     406549      +6298     
================================================
+ Hits         292128     295502      +3374     
- Misses        89191      92241      +3050     
+ Partials      18932      18806       -126     
Flag Coverage Δ
integration 32.5902% <ø> (?)
unit 72.9829% <ø> (-0.0033%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9340% <ø> (-0.0144%) ⬇️
br 48.7398% <ø> (-4.3350%) ⬇️

@Defined2014 Defined2014 changed the title tests, sessionctx: move IT tests in sessionctx to integrationtest tests, sessionctx: move IT tests in sessionctx, sessiontxn to integrationtest Sep 24, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@Defined2014
Copy link
Contributor Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 25, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-24 07:49:15.716263855 +0000 UTC m=+174745.434606069: ☑️ agreed by hawkingrei.
  • 2023-09-25 07:10:41.735909796 +0000 UTC m=+258831.454252010: ☑️ agreed by SeaRise.

@Defined2014 Defined2014 changed the title tests, sessionctx: move IT tests in sessionctx, sessiontxn to integrationtest *: move IT tests in sessionctx, sessiontxn to integrationtest Sep 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0a04a04 into pingcap:master Sep 25, 2023
@Defined2014 Defined2014 deleted the move-sessionctx branch November 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants