bindinfo, tests: move IT test cases in bindinfo to `tests/integrationtest` #47159

Defined2014 · 2023-09-21T05:50:33Z

What problem does this PR solve?

Issue Number: close #47124

Problem Summary: Move 12 test cases.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-09-21T05:50:44Z

Hi @Defined2014. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014 · 2023-09-21T05:50:49Z

/ok-to-test

ti-chi-bot · 2023-09-21T05:51:04Z

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-21T05:51:17Z

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-21T05:52:04Z

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014 · 2023-09-21T05:53:48Z

/label ok-to-test

Defined2014 · 2023-09-21T06:02:24Z

/label-remove needs-ok-to-test

Defined2014 · 2023-09-21T06:03:29Z

/remove-label needs-ok-to-test

ti-chi-bot · 2023-09-21T06:03:31Z

@Defined2014: The label(s) needs-ok-to-test cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, needs-cherry-pick-release-6.6, needs-cherry-pick-release-7.0, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.2, needs-cherry-pick-release-7.3, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, affects-6.6, affects-7.0, affects-7.1, affects-7.2, affects-7.3, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5, may-affects-6.6, may-affects-7.0, may-affects-7.1, may-affects-7.2, may-affects-7.3.

In response to this:

/remove-label needs-ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

purelind · 2023-09-21T06:05:06Z

/remove-label needs-ok-to-test

ti-chi-bot · 2023-09-21T06:05:08Z

@purelind: The label(s) needs-ok-to-test cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, ok-to-test, needs-more-info, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, needs-cherry-pick-release-6.6, needs-cherry-pick-release-7.0, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.2, needs-cherry-pick-release-7.3, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, affects-6.6, affects-7.0, affects-7.1, affects-7.2, affects-7.3, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5, may-affects-6.6, may-affects-7.0, may-affects-7.1, may-affects-7.2, may-affects-7.3.

In response to this:

/remove-label needs-ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Defined2014 · 2023-09-21T06:06:52Z

/test all

codecov · 2023-09-21T06:15:53Z

Codecov Report

Merging #47159 (435a788) into master (3f3b07e) will decrease coverage by 0.2970%.
Report is 14 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47159        +/-   ##
================================================
- Coverage   72.9609%   72.6640%   -0.2970%     
================================================
  Files          1338       1359        +21     
  Lines        399186     405751      +6565     
================================================
+ Hits         291250     294835      +3585     
- Misses        89120      92176      +3056     
+ Partials      18816      18740        -76

Flag	Coverage Δ
integration	`30.8873% <ø> (?)`
unit	`72.9961% <ø> (+0.0351%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`84.9620% <ø> (ø)`
br	`48.7477% <ø> (-4.1944%)`	⬇️

Defined2014 · 2023-09-21T07:06:01Z

/test mysql-test

tiprow · 2023-09-21T07:06:39Z

@Defined2014: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014 · 2023-09-21T09:08:05Z

/cc @tiancaiamao

Defined2014 · 2023-09-21T09:08:12Z

/cc @SeaRise

ti-chi-bot · 2023-09-21T09:08:15Z

@Defined2014: GitHub didn't allow me to request PR reviews from the following users: SeaRise.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @SeaRise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Defined2014 · 2023-09-21T09:08:19Z

/cc @bb7133

Defined2014 · 2023-09-22T02:06:17Z

/cc @YangKeao

YangKeao

LGTM

ti-chi-bot · 2023-09-22T02:14:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-09-22T02:14:07Z

[LGTM Timeline notifier]

Timeline:

2023-09-22 00:51:20.899289437 +0000 UTC m=+824246.866877468: ☑️ agreed by hawkingrei.
2023-09-22 02:14:06.118930905 +0000 UTC m=+829212.086518950: ☑️ agreed by YangKeao.

update

b557991

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 21, 2023

purelind removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 21, 2023

update tests

02eacba

Defined2014 force-pushed the move-bindinfo branch from 8656f04 to 02eacba Compare September 21, 2023 06:27

Defined2014 added 2 commits September 21, 2023 14:37

udpate

d25e317

update

435a788

ti-chi-bot bot requested a review from tiancaiamao September 21, 2023 09:08

ti-chi-bot bot requested a review from bb7133 September 21, 2023 09:08

hawkingrei approved these changes Sep 22, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2023

ti-chi-bot bot requested a review from YangKeao September 22, 2023 02:06

YangKeao approved these changes Sep 22, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2023

ti-chi-bot bot merged commit ae11336 into pingcap:master Sep 22, 2023

Defined2014 deleted the move-bindinfo branch November 21, 2023 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bindinfo, tests: move IT test cases in bindinfo to `tests/integrationtest` #47159

bindinfo, tests: move IT test cases in bindinfo to `tests/integrationtest` #47159

Defined2014 commented Sep 21, 2023 •

edited

Loading

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

purelind commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

codecov bot commented Sep 21, 2023 •

edited

Loading

Defined2014 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 22, 2023

YangKeao left a comment

ti-chi-bot bot commented Sep 22, 2023

ti-chi-bot bot commented Sep 22, 2023

bindinfo, tests: move IT test cases in bindinfo to tests/integrationtest #47159

bindinfo, tests: move IT test cases in bindinfo to tests/integrationtest #47159

Conversation

Defined2014 commented Sep 21, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

purelind commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

Defined2014 commented Sep 21, 2023

tiprow bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

ti-chi-bot bot commented Sep 21, 2023

Defined2014 commented Sep 21, 2023

Defined2014 commented Sep 22, 2023

YangKeao left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 22, 2023

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

bindinfo, tests: move IT test cases in bindinfo to `tests/integrationtest` #47159

bindinfo, tests: move IT test cases in bindinfo to `tests/integrationtest` #47159

Defined2014 commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading